[webkit-reviews] review granted: [Bug 93874] Add a was-inserted-into-tree notification to RenderObject : [Attachment 158361] Proposed change 2: Fixed the Windows build by exposing enclosingRenderNamedFlowThread.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Julien Chaffraix
<jchaffraix at webkit.org>'s request for review:
Bug 93874: Add a was-inserted-into-tree notification to RenderObject
https://bugs.webkit.org/show_bug.cgi?id=93874

Attachment 158361: Proposed change 2: Fixed the Windows build by exposing
enclosingRenderNamedFlowThread.
https://bugs.webkit.org/attachment.cgi?id=158361&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158361&action=review


LGTM.

> Source/WebCore/rendering/RenderQuote.cpp:53
> +void RenderQuote::insertedIntoTree()

It seems we can remove this, no?  This just needs to be a comment, not an
implementation.

> Source/WebCore/rendering/RenderQuote.h:47
> +    virtual void insertedIntoTree() OVERRIDE;

Please remove. :)