[webkit-reviews] review granted: [Bug 94154] [chromium] Replace destRect with destOffset in texture upload : [Attachment 158649] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 15:34:58 PDT 2012


James Robinson <jamesr at chromium.org> has granted Alexandre Elias
<aelias at chromium.org>'s request for review:
Bug 94154: [chromium] Replace destRect with destOffset in texture upload
https://bugs.webkit.org/show_bug.cgi?id=94154

Attachment 158649: Patch
https://bugs.webkit.org/attachment.cgi?id=158649&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158649&action=review


> Source/WebCore/ChangeLog:13
> +	   "IntRect destRect" by "IntPoint destOffset".

According to the WebCore geometry system, offsets should be represented by
IntSize, not IntPoint.	Mind search-replacing the type before landing?


More information about the webkit-reviews mailing list