[webkit-reviews] review denied: [Bug 93939] Add support for Skia Magnifier filter to Chromium layers : [Attachment 158248] Patch

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has denied Zachary Kuznia
<zork at chromium.org>'s request for review:
Bug 93939: Add support for Skia Magnifier filter to Chromium layers
https://bugs.webkit.org/show_bug.cgi?id=93939

Attachment 158248: Patch
https://bugs.webkit.org/attachment.cgi?id=158248&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158248&action=review


> Source/Platform/chromium/public/WebFilterOperation.h:74
> +    WebRect zoomRect() const

newline between functions, please

> Source/Platform/chromium/public/WebFilterOperation.h:79
> +    int zoomInset() const

what does this field mean?  What's a zoom inset?

> Source/Platform/chromium/public/WebFilterOperation.h:108
> +    WebRect m_zoomRect;
> +    int m_zoomInset;

It sucks to grow this by even more - can you make some of the existing fields
more generic and share data space?

> Source/WebCore/platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:38
> +#include "SkMagnifierImageFilter.h"

I can't find this file in my skia checkout - has it not landed yet? Please link
the skia rev or codereview so we can make sure the DEPS all happen in order

> Source/WebCore/platform/graphics/filters/FilterOperation.h:69
> +	   ZOOM,

Why are you patching WebCore::FilterOperation?	Do we need to use this in
cross-platform code (i.e. outside of chromium compositor stuff)?