[webkit-reviews] review granted: [Bug 89238] Accumulate sub-pixel offsets through layers and transforms : [Attachment 158038] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Levi Weintraub <leviw at chromium.org>'s
request for review:
Bug 89238: Accumulate sub-pixel offsets through layers and transforms
https://bugs.webkit.org/show_bug.cgi?id=89238

Attachment 158038: Patch
https://bugs.webkit.org/attachment.cgi?id=158038&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158038&action=review


This change looks fine.

> Source/WebCore/rendering/RenderLayer.h:719
> +    void paintLayerContents(RenderLayer* rootLayer, GraphicsContext*, const
LayoutRect& paintDirtyRect, const LayoutSize& subPixelAccumulation,

You mentioned you wanted to ASSERT these were never over 1,1.

> Source/WebCore/rendering/RenderObject.h:692
> +    FloatQuad localToContainerQuad(const FloatQuad&, RenderBoxModelObject*
repaintContainer, bool snapOffsetForTransforms = true, bool fixed = false,
bool* wasFixed = 0) const;
> +    FloatPoint localToContainerPoint(const FloatPoint&,
RenderBoxModelObject* repaintContainer, bool snapOffsetForTransforms = true,
bool fixed = false, bool* wasFixed = 0) const;

Not another bool!