[webkit-reviews] review requested: [Bug 84210] [chromium] Add tracing for active composited animations : [Attachment 158628] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 13:38:11 PDT 2012


vollick at chromium.org has asked	for review:
Bug 84210: [chromium] Add tracing for active composited animations
https://bugs.webkit.org/show_bug.cgi?id=84210

Attachment 158628: Patch
https://bugs.webkit.org/attachment.cgi?id=158628&action=review

------- Additional Comments from vollick at chromium.org
(In reply to comment #12)
> (From update of attachment 158603 [details])
> View in context:
https://bugs.webkit.org/attachment.cgi?id=158603&action=review
>
> > Source/WebCore/platform/graphics/chromium/LayerChromium.h:97
> > +	 virtual bool isImpl() const OVERRIDE { return false; }
>
> This is gross to add just for debugging.  Can you find another way?

Yeah, it is gross. I tried what Nat suggested and now CCActiveAnimations know
if
they are the 'controlling instance' (defined in CCActiveAnimation.h). Does that
seem any better?


More information about the webkit-reviews mailing list