[webkit-reviews] review denied: [Bug 93723] [NRWT] The nrwt should check the contents of the skipped files with --lint-test-files : [Attachment 158558] proposed fix

[bugzilla-daemon at webkit.org]

Dirk Pranke <dpranke at chromium.org> has denied Kristóf Kosztyó
<kkristof at inf.u-szeged.hu>'s request for review:
Bug 93723: [NRWT] The nrwt should check the contents of the skipped files with
--lint-test-files
https://bugs.webkit.org/show_bug.cgi?id=93723

Attachment 158558: proposed fix
https://bugs.webkit.org/attachment.cgi?id=158558&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
expectation_for_skipped_test() won't set .warnings, so it seems unlikely that
this branch would ever execute. Also, checking for one warning and then
printing another seems like a bad idea. 

You should just test if the file (or directory) exists here and add a warning
directly (or add that code into expectation_for_skipped_test(). 

Also, this change needs a test.