[webkit-reviews] review requested: [Bug 94050] [chromium] set scissorRect per quad so that quads are correctly clipped : [Attachment 158586] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 10:17:11 PDT 2012


Shawn Singh <shawnsingh at chromium.org> has asked  for review:
Bug 94050: [chromium] set scissorRect per quad so that quads are correctly
clipped
https://bugs.webkit.org/show_bug.cgi?id=94050

Attachment 158586: Patch
https://bugs.webkit.org/attachment.cgi?id=158586&action=review

------- Additional Comments from Shawn Singh <shawnsingh at chromium.org>
passes all unit tests and layout tests on osx.	In this patch I opted for the
always-scissor approach.  I felt like adding more logic to turn off scissoring
was over-engineering the solution without enough evidence that it's worth the
savings. If you want I can make a different solution that adds a bit more logic
passed into drawQuad, so that the quad can decide for itself whether to turn
off scissoring or not.	But, especially if we do intend to refactor quad types
to draw only their clipped/visible bounds, then maybe this solution is better
to keep things simple.


More information about the webkit-reviews mailing list