[webkit-reviews] review granted: [Bug 94115] [BlackBerry] Check for valid field focus before processing a spellcheck request : [Attachment 158572] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 15 08:34:17 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 94115: [BlackBerry] Check for valid field focus before processing a
spellcheck request
https://bugs.webkit.org/show_bug.cgi?id=94115

Attachment 158572: Patch
https://bugs.webkit.org/attachment.cgi?id=158572&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158572&action=review


LGTM.

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:540
> +	   return;

Could be made into a macro since we do this block a lot.


More information about the webkit-reviews mailing list