[webkit-reviews] review granted: [Bug 40272] The 2d.imageData.object.round canvas test is failing : [Attachment 158557] Rounding using lrint, handling halfway case, v3.

[bugzilla-daemon at webkit.org]

Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Dominik Röttsches
(drott) <dominik.rottsches at intel.com>'s request for review:
Bug 40272: The 2d.imageData.object.round canvas test is failing
https://bugs.webkit.org/show_bug.cgi?id=40272

Attachment 158557: Rounding using lrint, handling halfway case, v3.
https://bugs.webkit.org/attachment.cgi?id=158557&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158557&action=review


> Source/WTF/wtf/MathExtras.h:215
> +#pragma message("Falling back to casting for lrint(), causes rounding
inaccuracy in halfway case.")

I wonder if we should link to the bug report? but I guess it is fine