[webkit-reviews] review denied: [Bug 93444] Web Inspector: SourceFrame shouldn't be a View : [Attachment 158469] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Jan Keromnes
<janx at chromium.org>'s request for review:
Bug 93444: Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444

Attachment 158469: Patch
https://bugs.webkit.org/attachment.cgi?id=158469&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158469&action=review


> Source/WebCore/inspector/front-end/SourceFrame.js:-39
> -    this.element.addStyleClass("script-view");

You should remove the corresponding css definition.

> Source/WebCore/inspector/front-end/SourceFrame.js:-98
> -	   this._textEditor.show(this.element);

I guess you should either refactor View.js (see below) or preserve the original
behavior (store parent from show and use it in here).

> Source/WebCore/inspector/front-end/TabbedPane.js:461
> +	   if (this.isShowing())

This kind of change should be done in the View.js once for all view containers,
no need to specifically fix it for TabbedPane.