[webkit-reviews] review granted: [Bug 91125] IndexedDB: generate index keys for existing data in createIndex in front end : [Attachment 158377] Patch

[bugzilla-daemon at webkit.org]

Tony Chang <tony at chromium.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 91125: IndexedDB: generate index keys for existing data in createIndex in
front end
https://bugs.webkit.org/show_bug.cgi?id=91125

Attachment 158377: Patch
https://bugs.webkit.org/attachment.cgi?id=158377&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158377&action=review


> Source/WebCore/Modules/indexeddb/IDBObjectStore.cpp:359
> +

Nit: extra blank line?

> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:223
> +static bool makeIndexWriters(IDBObjectStoreBackendImpl* objectStore,
PassRefPtr<IDBKey> primaryKey, bool keyWasGenerated, const Vector<String>
indexNames, const Vector<IDBObjectStoreBackendInterface::IndexKeys>& indexKeys,
Vector<OwnPtr<IndexWriter> > *indexWriters, String *errorMessage)

Nit: * in the wrong spot for indexWriters and errorMessage.

> Source/WebCore/Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:245
> +	   indexWriter = adoptPtr(new IndexWriter(index->metadata(), keys));

Nit: Maybe move the variable declaration into the same line to have 1 less line
of code?

> Source/WebKit/chromium/src/WebIDBObjectStoreImpl.cpp:97
> +    for (size_t i = 0; i < webIndexNames.size(); i++)

Nit: ++i