[webkit-reviews] review granted: [Bug 74346] Text selection in text area in auto scroll mode goes wrong. : [Attachment 158495] Patch

Tue Aug 14 21:17:49 PDT 2012

Ojan Vafai <ojan at chromium.org> has granted Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 74346: Text selection in text area in auto scroll mode goes wrong.
https://bugs.webkit.org/show_bug.cgi?id=74346

Attachment 158495: Patch
https://bugs.webkit.org/attachment.cgi?id=158495&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158495&action=review

Looks great. Please address my last comments on the test and then feel free to
commit.

Just to be sure, you verified that the test still fails without your fix and
without the setTimeout, right? :)

> LayoutTests/fast/events/autoscroll-in-textarea.html:1
> +<!doctype html>

Nit: typically we uppercase doctype:
<!DOCTYPE html>

> LayoutTests/fast/events/autoscroll-in-textarea.html:42
> +    testRunner.waitUntilDone();

Now that you don't have the setTimeout, you don't need this line.

> LayoutTests/fast/events/autoscroll-in-textarea.html:69
> +if (window.testRunner)
> +    testRunner.notifyDone();

and without the waitUntilDone call above, you don't need to notifyDone either.