[webkit-reviews] review requested: [Bug 93793] Improve the use of strings in CSS : [Attachment 158490] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 21:02:34 PDT 2012
Benjamin Poulain <benjamin at webkit.org> has asked for review:
Bug 93793: Improve the use of strings in CSS
https://bugs.webkit.org/show_bug.cgi?id=93793
Attachment 158490: Patch
https://bugs.webkit.org/attachment.cgi?id=158490&action=review
------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
Looks like I have addressed the two mistakes, so let's put this version for
review.
Something to be careful when reviewing:
stringBuilder::toString() return String::empty(). Previously, some functions
would have returned a null string instead of an empty string.
I think I got them covered but I may have missed something so a careful review
would be appreciated.
More information about the webkit-reviews
mailing list