[webkit-reviews] review granted: [Bug 93694] FileWriter fails with assertion when trying to write empty Blob : [Attachment 157660] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 19:47:07 PDT 2012


Kent Tamura <tkent at chromium.org> has granted Kinuko Yasuda
<kinuko at chromium.org>'s request for review:
Bug 93694: FileWriter fails with assertion when trying to write empty Blob
https://bugs.webkit.org/show_bug.cgi?id=93694

Attachment 157660: Patch
https://bugs.webkit.org/attachment.cgi?id=157660&action=review

------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157660&action=review


> LayoutTests/fast/filesystem/file-writer-empty-blob.html:4
> +<html>
> + <head>
> +    <title>File Writer with empty Blob</title>

Inconsistent indentation

> LayoutTests/fast/filesystem/resources/file-writer-empty-blob.js:28
> +setupAndRunTest(2*1024*1024, 'file-writer-empty-blob', runTest);

Need spaces before and after '*'

> LayoutTests/fast/filesystem/workers/file-writer-empty-blob.html:4
> +<html>
> + <head>
> +    <title>File Writer with empty Blob in Worker</title>

inconsistent indentation


More information about the webkit-reviews mailing list