[webkit-reviews] review denied: [Bug 74346] Text selection in text area in auto scroll mode goes wrong. : [Attachment 157713] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has denied Sukolsak Sakshuwong
<sukolsak at google.com>'s request for review:
Bug 74346: Text selection in text area in auto scroll mode goes wrong.
https://bugs.webkit.org/show_bug.cgi?id=74346

Attachment 157713: Patch
https://bugs.webkit.org/attachment.cgi?id=157713&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157713&action=review


R- for the 100ms timeout. The C++ side looks good to me.

> LayoutTests/fast/events/autoscroll-in-textarea.html:57
> +	   var x = textarea.offsetLeft + 20;
> +	   var y = textarea.offsetTop + 8;

Can you make these less magic? For x, you can do textarea.offsetLeft +
textarea.offsetWidth / 2.

For y, would adding 1 be enough?

> LayoutTests/fast/events/autoscroll-in-textarea.html:63
> +    setTimeout(autoscrollTestPart2, 100);

Do you need this 100ms? 0 should be sufficient I would think. No need to make
the test take ~100ms longer.