[webkit-reviews] review canceled: [Bug 93863] [css3-text] Add CSS3 Text decoration compile flag : [Attachment 158451] Patch

[bugzilla-daemon at webkit.org]

Julien Chaffraix <jchaffraix at webkit.org> has canceled Bruno Abinader
<bruno.abinader at basyskom.com>'s request for review:
Bug 93863: [css3-text] Add CSS3 Text decoration compile flag
https://bugs.webkit.org/show_bug.cgi?id=93863

Attachment 158451: Patch
https://bugs.webkit.org/attachment.cgi?id=158451&action=review

------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158451&action=review


The change is fine.

But the test landed in bug 90959 (fast/css/text-decoration-line.html) is not
failing as it should. I think this is because you provide both properties
(non-prefixed and prefixed) in the test rendering the test basically useless as
it passes regardless of whether we render the prefixed version properly. This
should be fixed and tested before this gets into the tree.

> Source/WebCore/ChangeLog:32
> +	   (WebCore::StyleResolver::collectMatchingRulesForList):

Please fill in the details in the ChangeLog, especially since you are
retroactively protecting some of your implementation.