[webkit-reviews] review granted: [Bug 93884] Change behavior of MasqueradesAsUndefined to better accommodate DFG changes : [Attachment 158448] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 93884: Change behavior of MasqueradesAsUndefined to better accommodate DFG
changes
https://bugs.webkit.org/show_bug.cgi?id=93884

Attachment 158448: Patch
https://bugs.webkit.org/attachment.cgi?id=158448&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158448&action=review


r=me with one repeated comment below.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:616
> +   
m_jit.graph().globalObjectFor(m_jit.graph()[operand].codeOrigin)->masqueradesAs
UndefinedWatchpoint()->add(speculationWatchpoint());

You should only do this if the watchpoint is still valid. If it's invalid,
adding to it doesn't make sense.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:670
> +   
m_jit.graph().globalObjectFor(m_jit.graph()[operand].codeOrigin)->masqueradesAs
UndefinedWatchpoint()->add(speculationWatchpoint());

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT32_64.cpp:3817
> +	  
m_jit.graph().globalObjectFor(node.codeOrigin)->masqueradesAsUndefinedWatchpoin
t()->add(speculationWatchpoint());

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:581
> +   
m_jit.graph().globalObjectFor(m_jit.graph()[operand].codeOrigin)->masqueradesAs
UndefinedWatchpoint()->add(speculationWatchpoint());

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:635
> +   
m_jit.graph().globalObjectFor(m_jit.graph()[operand].codeOrigin)->masqueradesAs
UndefinedWatchpoint()->add(speculationWatchpoint());

Ditto.

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT64.cpp:3808
> +	  
m_jit.graph().globalObjectFor(node.codeOrigin)->masqueradesAsUndefinedWatchpoin
t()->add(speculationWatchpoint());

Ditto.