[webkit-reviews] review granted: [Bug 93997] [Chromium] Fix warnings on Windows build : [Attachment 158365] Patch

[bugzilla-daemon at webkit.org]

Kentaro Hara <haraken at chromium.org> has granted Scott Graham
<scottmg at chromium.org>'s request for review:
Bug 93997: [Chromium] Fix warnings on Windows build
https://bugs.webkit.org/show_bug.cgi?id=93997

Attachment 158365: Patch
https://bugs.webkit.org/attachment.cgi?id=158365&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158365&action=review


>>> Source/WebKit/chromium/tests/CCRenderSurfaceFiltersTest.cpp:56
>>>	
EXPECT_TRUE(isCombined(WebFilterOperation::createGrayscaleFilter(0.5)));
>> 
>> Don't you also need to change 0.5 to 0.5f?
> 
> No, 0.5 is exactly representable as a float, so there's no truncation.

Makes sense. Then let's add the comment. People will wonder why this test uses
0.3f and 0.5.