[webkit-reviews] review requested: [Bug 93643] Preserve styling elements in DeleteSelectionCommand : [Attachment 158424] Proposed Patch

Tue Aug 14 15:25:13 PDT 2012

Alice Cheng <alice_cheng at apple.com> has asked  for review:
Bug 93643: Preserve styling elements in DeleteSelectionCommand
https://bugs.webkit.org/show_bug.cgi?id=93643

Attachment 158424: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=158424&action=review

------- Additional Comments from Alice Cheng <alice_cheng at apple.com>
Modified command to preserve "undoness" of DeleteSelectionCommand
Modified the moving, so that it only moves when <head> is content editable

Also Thank Ryosuke and Darin for the review and comments!! I do have a question
on Ryosuke's comment: if we do not remove these elements in certain places,
then where shall we keep them, if their parents are to be removed as well (for
example their parents are in a DeleteSelectionComand's selection)? <head> was a
choice, since according to W3C, it is a safer place for these elements. Maybe
you have better understanding on the removing procedure than i do. Let me know
=)