[webkit-reviews] review granted: [Bug 93150] Array checks should use the structure, not the class info : [Attachment 158235] the patch

[bugzilla-daemon at webkit.org]

Mark Hahnenberg <mhahnenberg at apple.com> has granted Filip Pizlo
<fpizlo at apple.com>'s request for review:
Bug 93150: Array checks should use the structure, not the class info
https://bugs.webkit.org/show_bug.cgi?id=93150

Attachment 158235: the patch
https://bugs.webkit.org/attachment.cgi?id=158235&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158235&action=review


Looks good overall except for minor fix. Also placate windows and style bot
please :-)

> Source/JavaScriptCore/jit/JITPropertyAccess32_64.cpp:214
> +    addSlowCase(branchPtr(NotEqual, Address(regT1,
JSCell::classInfoOffset()), TrustedImmPtr(&JSArray::s_info)));

Should this be Structure::classInfoOffset()?