[webkit-reviews] review requested: [Bug 93900] [CSS Shaders][Chromium] Filters area applied twice when CustomFilterOperation is in the list : [Attachment 158411] Patch V1
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 14:03:35 PDT 2012
Chiculita Alexandru <achicu at adobe.com> has asked for review:
Bug 93900: [CSS Shaders][Chromium] Filters area applied twice when
CustomFilterOperation is in the list
https://bugs.webkit.org/show_bug.cgi?id=93900
Attachment 158411: Patch V1
https://bugs.webkit.org/attachment.cgi?id=158411&action=review
------- Additional Comments from Chiculita Alexandru <achicu at adobe.com>
Note that GraphicsLayerChromium::setBackgroundFilters is doing the same thing,
but in that case there's no software fallback.
GraphicsLayerChromium::setBackgroundFilters seems to be Chromium specific and I
don't know what would be the policy. It seems to be called only from C++.
Should I add an ASSERT_NOT_REACHED in that case or should I just remove the old
filters?
More information about the webkit-reviews
mailing list