[webkit-reviews] review granted: [Bug 93971] [V8] Refactor away IsolatedWorld : [Attachment 158389] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Dan Carney <dcarney at google.com>'s
request for review:
Bug 93971: [V8] Refactor away IsolatedWorld
https://bugs.webkit.org/show_bug.cgi?id=93971

Attachment 158389: Patch
https://bugs.webkit.org/attachment.cgi?id=158389&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158389&action=review


> Source/WebCore/bindings/v8/DOMWrapperWorld.h:45
> +    static PassRefPtr<DOMWrapperWorld> create(int worldId = mainWorldId) {
return adoptRef(new DOMWrapperWorld(worldId)); }

Can you make createMainWorld be a separate function?  It's a bit too tempting
to call create() and duplicate the main world.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:49
> +	   if (m_worldId != mainWorldId)
> +	       isolatedWorldCount--;

I would just make this unconditional and have a domWrapperWorldCount.  There's
always going to be a main world, so we know how to interpet the value.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:57
> +

Please remove this blank line.

> Source/WebCore/bindings/v8/DOMWrapperWorld.h:58
> +    DOMWrapperWorld(int worldId): m_worldId(worldId)

This should be split onto two lines with the : as the first character of the
second line (indented four spaces).