[webkit-reviews] review canceled: [Bug 93904] old-run-webkit-tests should skip reference tests with all file extensions, not just .html. : [Attachment 158395] doh

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has canceled Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 93904: old-run-webkit-tests should skip reference tests with all file
extensions, not just .html.
https://bugs.webkit.org/show_bug.cgi?id=93904

Attachment 158395: doh
https://bugs.webkit.org/attachment.cgi?id=158395&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158395&action=review


> Tools/Scripts/old-run-webkit-tests:2565
> +    my $extensionStr = join("|", @extensions);
> +    my $regexStr = "-$expectedTag(-$mismatchTag)?\\.(".$extensionStr.")\$";

This looks suspiciously like hungarian notation, which we don't do :)

> Tools/Scripts/old-run-webkit-tests:2572
> +    foreach (@extensions) {

you can do foreach my $extension (@extensions) and then use the nice, named
$extension instead of the meaningless $_ below.