[webkit-reviews] review denied: [Bug 74625] Clang doesn't optimize away undefined OwnPtr copy constructor : [Attachment 120413] Make PassOwnPtr derive from OwnPtr

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 12:44:26 PDT 2012


Darin Adler <darin at apple.com> has denied Adrienne Walker <enne at google.com>'s
request for review:
Bug 74625: Clang doesn't optimize away undefined OwnPtr copy constructor
https://bugs.webkit.org/show_bug.cgi?id=74625

Attachment 120413: Make PassOwnPtr derive from OwnPtr
https://bugs.webkit.org/attachment.cgi?id=120413&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
We should fix this using a move constructor. Not by making PassOwnPtr derive
from OwnPtr. I suggest starting with Anders’s patch and making it work.


More information about the webkit-reviews mailing list