[webkit-reviews] review granted: [Bug 93108] [chromium] Add a test to WebFrameTest for selectRange and visiblePositionForWindowPoint. : [Attachment 158348] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Iain Merrick <husky at chromium.org>'s
request for review:
Bug 93108: [chromium] Add a test to WebFrameTest for selectRange and
visiblePositionForWindowPoint.
https://bugs.webkit.org/show_bug.cgi?id=93108

Attachment 158348: Patch
https://bugs.webkit.org/attachment.cgi?id=158348&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158348&action=review


Thanks for following up on the tests.

> Source/WebKit/chromium/tests/WebFrameTest.cpp:972
> +static WebPoint topLeft(const WebRect& rect)
> +{
> +    return WebPoint(rect.x, rect.y);
> +}

Should we add this function to WebRect?

> Source/WebKit/chromium/tests/WebFrameTest.cpp:980
> +    // FIXME: If we don't subtract 1 from the x- and y-coordinates of the
> +    // selection bounds, selectRange() will select the *next* element.
That's
> +    // strictly correct, as hit-testing checks the pixel to the lower-right
of
> +    // the input coordinate, but it's a wart on the API.
> +    return WebPoint(rect.x + rect.width - 1, rect.y + rect.height - 1);

Interesting.