[webkit-reviews] review granted: [Bug 93926] [BlackBerry] Assertion failure in AppCacheGroup : [Attachment 158197] Patch to avoid the assertion failure

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 07:14:31 PDT 2012


Rob Buis <rwlbuis at gmail.com> has granted George Staikos <staikos at kde.org>'s
request for review:
Bug 93926: [BlackBerry] Assertion failure in AppCacheGroup
https://bugs.webkit.org/show_bug.cgi?id=93926

Attachment 158197: Patch to avoid the assertion failure
https://bugs.webkit.org/attachment.cgi?id=158197&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158197&action=review


Looks good, but I think the ChangeLog needs to be cleaned up before landing.

> Source/WebCore/ChangeLog:5
> +	   change.

This seems to be the description part. I advise to stick to bug title here
("[BlackBerry] Assertion failure in AppCacheGroup") and move/merge above lines
below Reviewed by.


More information about the webkit-reviews mailing list