[webkit-reviews] review denied: [Bug 93090] Web Inspector: requests filtering in network tab : [Attachment 158293] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 93090: Web Inspector: requests filtering in network tab
https://bugs.webkit.org/show_bug.cgi?id=93090

Attachment 158293: Patch
https://bugs.webkit.org/attachment.cgi?id=158293&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158293&action=review


Considering the scope of this patch the search controller change looks too
complicated to me.
I think this complexity is the result of hiding inspector footer and showing
again each time the checkbox state is changed.
We should update already shown footer instead.

> Source/WebCore/inspector/front-end/InspectorView.js:85
> +	       WebInspector.searchController.panelChanged();

cancelSearch call should be enough.