[webkit-reviews] review denied: [Bug 91630] Web Inspector: Incorrect XHR responses when two async xhrs are sent synchronously : [Attachment 158306] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 14 06:14:29 PDT 2012


Vsevolod Vlasov <vsevik at chromium.org> has denied Pavel Chadnov
<chadnov at google.com>'s request for review:
Bug 91630: Web Inspector: Incorrect XHR responses when two async xhrs are sent
synchronously
https://bugs.webkit.org/show_bug.cgi?id=91630

Attachment 158306: Patch
https://bugs.webkit.org/attachment.cgi?id=158306&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158306&action=review


> Source/WebCore/loader/SubresourceLoader.cpp:204
> +	       m_isRevalidated = true;

Adding new field seems too intrusive, instrumentation call would be enough.
But after looking at it for a bit more I see that we already have a 304 check
in InspectorResourceAgent::didReceiveResponse, we could just reuse it.


More information about the webkit-reviews mailing list