[webkit-reviews] review denied: [Bug 93444] Web Inspector: SourceFrame shouldn't be a View : [Attachment 158151] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Jan Keromnes
<janx at chromium.org>'s request for review:
Bug 93444: Web Inspector: SourceFrame shouldn't be a View
https://bugs.webkit.org/show_bug.cgi?id=93444

Attachment 158151: Patch
https://bugs.webkit.org/attachment.cgi?id=158151&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158151&action=review


> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:66
> +    _onTextEditorWillHide: function()

You can't override private methods in a different file. _bar are only used
within single file.

> Source/WebCore/inspector/front-end/SourceFrame.js:-98
> -	   this._textEditor.show(this.element);

This still changes the behavior. We used to append the text editor upon showing
it in the screen, i.e. lazily. Now it is appended right away. Why did you
change this?