[webkit-reviews] review granted: [Bug 93929] [Forms] Make input type "time" to use multiple field time input UI : [Attachment 158276] Patch 4
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Aug 14 03:47:17 PDT 2012
Kent Tamura <tkent at chromium.org> has granted yosin at chromium.org's request for
review:
Bug 93929: [Forms] Make input type "time" to use multiple field time input UI
https://bugs.webkit.org/show_bug.cgi?id=93929
Attachment 158276: Patch 4
https://bugs.webkit.org/attachment.cgi?id=158276&action=review
------- Additional Comments from Kent Tamura <tkent at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158276&action=review
> Source/WebCore/html/TimeInputType.cpp:283
> +#endif // ENABLE(INPUT_TYPE_TIME_MULTIPLE_FIELDS)
The comment is confusing. I guess some people recognize the code just above
the comment is enabled if ENABLE(INPUT_TYPE_TIME_MULTIPLE_FILEDS). We had
better remove the comment because we don't have a common comment notation for
the end of #else block.
More information about the webkit-reviews
mailing list