[webkit-reviews] review denied: [Bug 93898] Add optional debug logging when we fall into/out of threaded scrolling : [Attachment 158145] we needn't care about swapping to the main thread when we don't support threaded scrolling

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Tim Horton
<timothy_horton at apple.com>'s request for review:
Bug 93898: Add optional debug logging when we fall into/out of threaded
scrolling
https://bugs.webkit.org/show_bug.cgi?id=93898

Attachment 158145: we needn't care about swapping to the main thread when we
don't support threaded scrolling
https://bugs.webkit.org/attachment.cgi?id=158145&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=158145&action=review


> Source/WebCore/page/scrolling/ScrollingCoordinator.h:154
> -    void setShouldUpdateScrollLayerPositionOnMainThread(bool);
> +    void setReasonsForUpdatingScrollLayerPositionOnMainThread(unsigned);

Setting "reasons for" doesn't necessarily imply that it will actually do
anything, so I'd prefer staying closer to the old name. Also, using unsigned
for a bitmask of known enum values is pretty icky. Typedef please!