[webkit-reviews] review requested: [Bug 33604] iframe.contentWindow doesn't fire DOMContentLoaded (implement DOMFrameContentLoaded?) : [Attachment 158148] patch proposal

[bugzilla-daemon at webkit.org]

arno. <arno at renevier.net> has asked  for review:
Bug 33604: iframe.contentWindow doesn't fire DOMContentLoaded (implement
DOMFrameContentLoaded?)
https://bugs.webkit.org/show_bug.cgi?id=33604

Attachment 158148: patch proposal
https://bugs.webkit.org/attachment.cgi?id=158148&action=review

------- Additional Comments from arno. <arno at renevier.net>
Currently, Firefox and Opera both implement DOMFrameContentLoaded events.

When a frame has been loaded, opera dispatches an event on the owner iframe.
This event then bubbles up to the window.

Firefox dispatch an event on the document on the owner iframe. It bubbles to
the window. target of that element is the iframe whose content has loaded. If
the owner document is itself contained in a frame, a event is dispatched to the
parent document. event target is still the frame when content has loaded (and
so on to the top of the parent document chain)

In this patch, I implement opera's behaviour, first because it was the simplest
way, and also because I don't really see advantage of ascending the event two
or more frames upper. But I can try to implement firefox's behaviour if that's
useful.