[webkit-reviews] review granted: [Bug 93424] Expand list of supported languages for RenderQuote to match WHATWG spec : [Attachment 158136] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 15:58:56 PDT 2012


Eric Seidel <eric at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 93424: Expand list of supported languages for RenderQuote to match WHATWG
spec
https://bugs.webkit.org/show_bug.cgi?id=93424

Attachment 158136: Patch
https://bugs.webkit.org/attachment.cgi?id=158136&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158136&action=review


LGTM.

> Source/WebCore/rendering/RenderQuote.cpp:94
> +    QUOTES_LANG("en",	    "\x201c", "\x201d", "\x2018", "\x2019");

Do you want to share this with basicQuotesData?


More information about the webkit-reviews mailing list