[webkit-reviews] review granted: [Bug 93244] [Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on ports using Cairo : [Attachment 158040] Copying buffer when src and dst are identical.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 10:54:51 PDT 2012


Kenneth Rohde Christiansen <kenneth at webkit.org> has granted Dominik Röttsches
(drott) <dominik.rottsches at intel.com>'s request for review:
Bug 93244: [Cairo] canvas/philip/tests/2d.drawImage.self.2.html test failing on
ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=93244

Attachment 158040: Copying buffer when src and dst are identical.
https://bugs.webkit.org/attachment.cgi?id=158040&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158040&action=review


> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:99
> +void ImageBuffer::draw(GraphicsContext* destContext, ColorSpace
styleColorSpace, const FloatRect& destRect, const FloatRect& srcRect,

why not write it out destinationContext or just destination.


More information about the webkit-reviews mailing list