[webkit-reviews] review granted: [Bug 93818] [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h : [Attachment 157957] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 13 10:32:15 PDT 2012
Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93818: [V8] Move GCEventData class from V8Binding.h to ScriptGCEvent.h
https://bugs.webkit.org/show_bug.cgi?id=93818
Attachment 157957: Patch
https://bugs.webkit.org/attachment.cgi?id=157957&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157957&action=review
> Source/WebCore/bindings/v8/ScriptGCEvent.h:58
> + GCEventData() : m_startTime(0.0), m_usedHeapSize(0) { }
This should be split onto a bunch of lines.
> Source/WebCore/bindings/v8/ScriptGCEvent.h:63
> + }
Can you add blank lines between member functions that have multi-line bodies?
More information about the webkit-reviews
mailing list