[webkit-reviews] review granted: [Bug 93807] [V8] Remove V8BindingHelpers : [Attachment 157943] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 13 10:27:16 PDT 2012


Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93807: [V8] Remove V8BindingHelpers
https://bugs.webkit.org/show_bug.cgi?id=93807

Attachment 157943: Patch
https://bugs.webkit.org/attachment.cgi?id=157943&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157943&action=review


> Source/WebCore/bindings/v8/NPV8Object.cpp:67
> +    if (!domWindow || !domWindow->frame() || domWindow !=
domWindow->frame()->domWindow())

This line of code is so broken.  I'll fix it as part of Bug 75793.


More information about the webkit-reviews mailing list