[webkit-reviews] review granted: [Bug 93792] [V8] Factor out exception related methods of V8Proxy : [Attachment 157937] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Kentaro Hara
<haraken at chromium.org>'s request for review:
Bug 93792: [V8] Factor out exception related methods of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=93792

Attachment 157937: Patch
https://bugs.webkit.org/attachment.cgi?id=157937&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157937&action=review


> Source/WebCore/bindings/v8/V8ThrowException.cpp:34
> +static v8::Handle<v8::Value> DOMExceptionStackGetter(v8::Local<v8::String>
name, const v8::AccessorInfo& info)

DOMExceptionStackGetter -> domExceptionStackGetter

> Source/WebCore/bindings/v8/V8ThrowException.cpp:40
> +static void DOMExceptionStackSetter(v8::Local<v8::String> name,
v8::Local<v8::Value> value, const v8::AccessorInfo& info)

DOMExceptionStackSetter -> domExceptionStackSetter

> Source/WebCore/bindings/v8/V8ThrowException.cpp:58
> +	   const char* message = 0;
> +	   return V8ThrowException::throwTypeError(message, isolate);

I would have combined these lines.

> Source/WebCore/bindings/v8/V8ThrowException.h:32
> +// The types of javascript errors that can be thrown.

This comment seems useless and probably should be removed.