[webkit-reviews] review denied: [Bug 93743] [chromium] Update HUD resources as a final step to drawing a frame : [Attachment 157808] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has denied Dana Jansens
<danakj at chromium.org>'s request for review:
Bug 93743: [chromium] Update HUD resources as a final step to drawing a frame
https://bugs.webkit.org/show_bug.cgi?id=93743

Attachment 157808: Patch
https://bugs.webkit.org/attachment.cgi?id=157808&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
I think I'd really prefer not to add some step that applies to all layers. 
Updating resources that you have already put in quads also seems potentially
fragile.  It may work now, but it seems easy to break, and we have no HUD
tests.

I think the only information that you don't have immediately post-calcDraw is
the screen space occlusion rects.  My thought is that you can save all but
those rects explicitly on the HUD layer right after calcDraw and then make the
HUD layer the container for the screen space occlusion rects to get those right
when it needs it during appendQuads since it goes last.