[webkit-reviews] review granted: [Bug 93851] Web Inspector: get rid of beforeTextChanged : [Attachment 158009] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 93851: Web Inspector: get rid of beforeTextChanged
https://bugs.webkit.org/show_bug.cgi?id=93851

Attachment 158009: Patch
https://bugs.webkit.org/attachment.cgi?id=158009&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=158009&action=review


> Source/WebCore/inspector/front-end/JavaScriptSourceFrame.js:184
> +	       for (var lineNumber = 0; lineNumber <
this._textEditor.linesCount; ++lineNumber) {

Maybe

if (!supportsBreakpointsOnEdit) {
    for (var lineNumber = 0; lineNumber < this._textEditor.linesCount;
++lineNumber) {
	var breakpointDecoration = this._textEditor.getAttribute(lineNumber,
"breakpoint");
	if (breakpointDecoration)
	    this._addBreakpointDecoration(lineNumber,
breakpointDecoration.condition, breakpointDecoration.enabled, true);
    }
}