[webkit-reviews] review canceled: [Bug 93581] Web Inspector: Feature Request - Adding mouse gesture for editing attribute values in elements/css panel : [Attachment 157921] Patch

[bugzilla-daemon at webkit.org]

Alexander Pavlov (apavlov) <apavlov at chromium.org> has canceled sam
<dsam2912 at gmail.com>'s request for review:
Bug 93581: Web Inspector: Feature Request - Adding mouse gesture for editing
attribute values in elements/css panel
https://bugs.webkit.org/show_bug.cgi?id=93581

Attachment 157921: Patch
https://bugs.webkit.org/attachment.cgi?id=157921&action=review

------- Additional Comments from Alexander Pavlov (apavlov)
<apavlov at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157921&action=review


Great work! Please fix the two nits, and we are good to land.

> Source/WebCore/inspector/front-end/TextPrompt.js:228
> +	   // Default.	

Comments of this kind should be omitted, since WebKit discourages comments that
add no value to the code (and sometimes it even discourages the comments that
do :)). If you feel strongly about having a comment here, it should be
something more useful, like "// Subclasses can implement." Even though I would
go with no comment at all (since the point is clear to the code readers.)

> Source/WebCore/inspector/front-end/UIUtils.js:314
> +  * @return {string}

Apologies, that was my fault: this line should actually be "@return {?string}"
(add the question-mark), since the returned value is nullable.