[webkit-reviews] review granted: [Bug 91405] z-index should work without position on flexitems : [Attachment 157776] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 12 16:39:27 PDT 2012


Tony Chang <tony at chromium.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 91405: z-index should work without position on flexitems
https://bugs.webkit.org/show_bug.cgi?id=91405

Attachment 157776: Patch
https://bugs.webkit.org/attachment.cgi?id=157776&action=review

------- Additional Comments from Tony Chang <tony at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157776&action=review


> Source/WebCore/rendering/RenderBox.h:47
> +    virtual bool requiresLayer() const OVERRIDE { return isRoot() ||
isOutOfFlowPositioned() || isRelPositioned() || isTransparent() ||
hasOverflowClip() || hasTransform() || hasHiddenBackface() || hasMask() ||
hasReflection() || hasFilter() || style()->specifiesColumns() ||
!style()->hasAutoZIndex(); }

Nit: Do we need the isOutOfFlowPositioned() || isRelPositioned() part of the
check now?


More information about the webkit-reviews mailing list