[webkit-reviews] review granted: [Bug 93759] [chromium] FPS HUD bitmap contains random noise on the mac : [Attachment 157853] Patch

[bugzilla-daemon at webkit.org]

Adrienne Walker <enne at google.com> has granted Vangelis Kokkevis
<vangelis at chromium.org>'s request for review:
Bug 93759: [chromium] FPS HUD bitmap contains random noise on the mac
https://bugs.webkit.org/show_bug.cgi?id=93759

Attachment 157853: Patch
https://bugs.webkit.org/attachment.cgi?id=157853&action=review

------- Additional Comments from Adrienne Walker <enne at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157853&action=review


R=me, with one robustness suggestion.

> Source/WebCore/platform/graphics/chromium/cc/CCHeadsUpDisplayLayerImpl.cpp:99

> +    if (canvasSize.fWidth != bounds().width() || canvasSize.fHeight !=
bounds().height())

If bounds() are empty the first time through this function, it'll crash on a
null m_hudCanvas below.  Maybe add a || !m_hudCanvas for safety?