[webkit-reviews] review granted: [Bug 93738] table cell.cellIndex should return -1 if there is no parent table : [Attachment 157894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 12 11:01:24 PDT 2012


Eric Seidel <eric at webkit.org> has granted Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 93738: table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738

Attachment 157894: Patch
https://bugs.webkit.org/attachment.cgi?id=157894&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157894&action=review


Thanks!

> Source/WebCore/html/HTMLTableCellElement.cpp:69
>      int index = 0;

We don't do K&R style anymore.	This declaration could be inline, right before
the for() below, but the patch overall is fine, and clearly the rest of this
file needs a style cleanup some day anyway.


More information about the webkit-reviews mailing list