[webkit-reviews] review granted: [Bug 86151] Reduce GradientAttributes object size : [Attachment 141283] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Aug 12 04:29:48 PDT 2012


Eric Seidel <eric at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 86151: Reduce GradientAttributes object size
https://bugs.webkit.org/show_bug.cgi?id=86151

Attachment 141283: Patch
https://bugs.webkit.org/attachment.cgi?id=141283&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=141283&action=review


> Source/WebCore/svg/GradientAttributes.h:80
> +    unsigned m_spreadMethod : 2;
> +    unsigned m_gradientUnits : 2;

Do we need to add any COMPILE_ASSERTS that these fit in two bits?  Will the
compiler warn us as-is?


More information about the webkit-reviews mailing list