[webkit-reviews] review granted: [Bug 90505] Set the access qualifier of two methods to query frame specific info of BitmapImage to protected. : [Attachment 151186] patch v.3

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Huang Dongsung
<luxtella at company100.net>'s request for review:
Bug 90505: Set the access qualifier of two methods to query frame specific info
of BitmapImage to protected.
https://bugs.webkit.org/show_bug.cgi?id=90505

Attachment 151186: patch v.3
https://bugs.webkit.org/attachment.cgi?id=151186&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=151186&action=review


>>> Source/WebCore/platform/graphics/cg/GraphicsContext3DCG.cpp:103
>>> +	 bool hasAlpha = image->isBitmapImage() ? image->currentFrameHasAlpha()
: true;
>> 
>> Why is this the right thing for gif and other multi-frame images?
> 
> Do we end up using the current frame anyway?

Ah, I've now read your ChangeLog, sorry.