[webkit-reviews] review granted: [Bug 93738] table cell.cellIndex should return -1 if there is no parent table : [Attachment 157874] Patch

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Pravin D <pravind.2k4 at gmail.com>'s
request for review:
Bug 93738: table cell.cellIndex should return -1 if there is no parent table
https://bugs.webkit.org/show_bug.cgi?id=93738

Attachment 157874: Patch
https://bugs.webkit.org/attachment.cgi?id=157874&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157874&action=review


It also appears we have a RenderTableCell::cellIndex() function which does
nothing and probably shoudl be removed.

> Source/WebCore/html/HTMLTableCellElement.cpp:73
> +    int index = -1;
> +    if (!parentElement() || !parentElement()->hasTagName(trTag))
> +	   return index;
> +
> +    index = 0;

I would have jsut used "return -1" here, and left int index = 0; as it was.  It
saves you a line of typing.