[webkit-reviews] review granted: [Bug 93756] AudioContext::createMediaStreamSource() must create a provider for local MediaStreams : [Attachment 157844] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Chris Rogers
<crogers at google.com>'s request for review:
Bug 93756: AudioContext::createMediaStreamSource() must create a provider for
local MediaStreams
https://bugs.webkit.org/show_bug.cgi?id=93756

Attachment 157844: Patch
https://bugs.webkit.org/attachment.cgi?id=157844&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157844&action=review


> Source/WebCore/Modules/webaudio/AudioContext.cpp:414
> +    node->setFormat(2, sampleRate());

Can a media stream only ever have two channels? A comment explaining why and/or
a FIXME would be helpful.