[webkit-reviews] review denied: [Bug 93747] Reduce the size of empty NinePieceImage objects. : [Attachment 157819] A patch apart

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has denied Andreas Kling <kling at webkit.org>'s
request for review:
Bug 93747: Reduce the size of empty NinePieceImage objects.
https://bugs.webkit.org/show_bug.cgi?id=93747

Attachment 157819: A patch apart
https://bugs.webkit.org/attachment.cgi?id=157819&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=157819&action=review


> Source/WebCore/rendering/style/NinePieceImage.h:37
> -class NinePieceImage {
> +class NinePieceImageData {

I think it would be better to use the normal RenderStyle DataRef<>/SET_VAR
pattern here. The advantage is that we can share the structure in cases where
it already exists and some other surround property is modified. It is also more
consistent.

We should also have separate version of SET_VAR for these two-level data
structure cases as currently we end up creating unnecessary structures when a
variable is set to the current value.