[webkit-reviews] review granted: [Bug 93745] no timeupdate events emitted for media controller : [Attachment 157828] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 93745: no timeupdate events emitted for media controller
https://bugs.webkit.org/show_bug.cgi?id=93745

Attachment 157828: Patch
https://bugs.webkit.org/attachment.cgi?id=157828&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=157828&action=review


> Source/WebCore/ChangeLog:13
> +	   Enforce the spec requirement that the timeupdate event is fired no
more often
> +	   than every 250ms.

Doesn't it say to fire them *at least* every 250ms?

> Source/WebCore/ChangeLog:17
> +	   Add a periodic firing timer to generat timeupdate events during
playback.

Nit: "generat" -> "generate"

> Source/WebCore/ChangeLog:25
> +	   (MediaController::updatePlaybackState): Start and ntop the
timeupdate timer.

Nit: "ntop" -> "stop"