[webkit-reviews] review granted: [Bug 93729] REGRESSION(r125159): ASSERTION FAILED: m_listsInvalidatedAtDocument.contains(list) in Document::unregisterNodeListCache : [Attachment 157822] Updated patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Arko Saha <arko at motorola.com>'s
request for review:
Bug 93729: REGRESSION(r125159): ASSERTION FAILED:
m_listsInvalidatedAtDocument.contains(list) in
Document::unregisterNodeListCache
https://bugs.webkit.org/show_bug.cgi?id=93729

Attachment 157822: Updated patch
https://bugs.webkit.org/attachment.cgi?id=157822&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=157822&action=review


> LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:10
> +if (window.testRunner) {
> +    testRunner.dumpAsText();
> +}

No curly brackets around a single line statement.

> LayoutTests/fast/dom/MicroData/propertynodelist-crash.html:19
> +    for (var i = 0; i < 10000; i++) { // force garbage collection
> +	   var s = new String("");
> +    }

Ditto.